-- Start of PGP signed section.
> On Thu, Sep 04, 2008 at 09:54:02PM +0100, Simon Riggs wrote:
> > * coding review - does it follow standard code guidelines? Are there
> > portability issues? Will it work on Windows/BSD etc? Are there
> > sufficient comments?
> >
> > * code review - does it do what it says, correctly?
>
> Just one thing though, I picked a random patch and started reading.
> However, the commitfest page doesn't link to anywhere that actually
> describes *what* the patch is trying to do. Many patches do have the
> design and the patch in one page, but some don't.
>
> I suppose what happens is the original patch comes with design and
> later a newer version is posted with just changes. The commitfest page
> points to the latter, losing former in the archive somewhere.
Yep, that is a problem; the previous emails about the patch and comments
are very valuable for reviewers.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
No comments:
Post a Comment