Monday, August 11, 2008

Re: [pgadmin-hackers] Support of INHERIT in existing tables (8.2+ releases)

On Sun, Aug 10, 2008 at 6:55 PM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:

> Sorry to answer so late, it was a lot of work to get everything working.
> Anyways, fixed.

No worries. Got the following warning:

./dlg/dlgTable.cpp: In member function 'void
dlgTable::OnAddTable(wxCommandEvent&)':
./dlg/dlgTable.cpp:1021: warning: unused variable 'row'

> Fixed in the same patch. Don't know if you want a backpatch for 1.8?

Thanks. I don't expect we're ever going to release another 1.8 - do you?

The only thing that looks a little odd with this patch is that the Add
button is always enabled, even if there is no table selected. That is
actually the existing behaviour, but it's a little more obvious now
the button is enabled when editing existing tables as well. Should we
fix that? My gut feeling is yes.

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

No comments: