Wednesday, September 10, 2008

Re: [HACKERS] [PATCH] Cleanup of GUC units code

Robert Haas wrote:
>bits...bytes...blocks...m...M
>
> I can't imagine that taking away the "B" is somehow going to
> be more clear.

If clarity is the goal, I'd want the following:

a) Verbosely spelling out the units in the default config file

temp_buffers = 16 megabytes
or
temp_buffers = 16 milliblocks :-)

Naive users who favor cut&paste will use the verbose words
that should leave little room for confusion. Power-users
who know the short forms from the docs will presumably have
read the descriptions.

b) having "show" show verbosely spelled out units.
db=# show temp_buffers;
temp_buffers
--------------
16000000 bytes
(1 row)

c) having "set" show a NOTICE with the verbose word for the units
db=# set temp_buffers = '16mb';
NOTICE: setting temp_buffers to 16000000 bytes


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

No comments: