Wednesday, June 25, 2008

Re: [HACKERS] CVS Head psql bug?

> Tatsuo Ishii <ishii@sraoss.co.jp> writes:
> > So the difference seems:
> > --as-needed -Wl,
> > is added to CVS Head.
>
> There is code in configure that's supposed to check whether or not that
> breaks readline. Would you look at the portion of config.log where it
> tests that, and see why it failed to notice a problem?

It seems configure only checks whether linking was successful. I think
it should check whether ./conftest was successful.

configure:25642: checking if gcc supports -Wl,--as-needed
configure:25674: gcc -o conftest -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Winline -Wendif-labels -fno-strict-aliasing -D_GNU_SOURCE -Wl,--as-needed conftest.c -lz -lreadline -lncurses -lcrypt -ldl -lm >&5
configure:25680: $? = 0
configure:25686: result: yes
configure:25765: using CFLAGS=-O2 -Wall -Wmissing-prototypes -Wpointer-arith -Winline -Wendif-labels -fno-strict-aliasing
configure:25767: using CPPFLAGS= -D_GNU_SOURCE
configure:25769: using LDFLAGS= -Wl,--as-needed
configure:25911: creating ./config.status
--
Tatsuo Ishii
SRA OSS, Inc. Japan

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

No comments: